Skip to content

Commit

Permalink
Add conditional to download and apply RELEASES file on Windows
Browse files Browse the repository at this point in the history
if he braveURL attribute is set in the metadata respone. This will
download the version specified, not the latest version is happening
before this commit.

Auditors: @bbondy, @clifton

Test plan:

  * Change version in package.json to something lower than current
  * Build browser on Windows
  * Install and check for updates
  * Ensure the following line is shown in SquirrelSetup.log
    It must contain a version number (0.19.16 in example below)

2017-09-25 18:04:13> CheckForUpdateImpl: Downloading RELEASES file from
https://brave-download.global.ssl.fastly.net/multi-channel/releases/beta/0.19.16/winx64
  • Loading branch information
aekeus committed Sep 25, 2017
1 parent 2513065 commit 3d955a6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/updater.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ var downloadHandler = (err, metadata) => {
if (process.platform === 'win32') {
// check versions to see if an update is required
if (metadata) {
if (metadata.braveURL) {
autoUpdater.setFeedURL(metadata.braveURL)
}
autoUpdater.checkForUpdates()
} else {
autoUpdater.emit(messages.UPDATE_NOT_AVAILABLE)
Expand Down

0 comments on commit 3d955a6

Please sign in to comment.