Set correct permission notification index

Auditors: @bridiver
syuan100 · Nov 9, 2017 · d379bd5 · d379bd5
1 parent ac993d7
commit d379bd5
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/app/filtering.js b/app/filtering.js
@@ -487,7 +487,7 @@ function registerPermissionHandler (session, partition) {
 
       // If this is a duplicate, clear the previous callback and use the new one
       if (permissionCallbacks[message]) {
-        permissionCallbacks[message](0, false, i)
+        permissionCallbacks[message](0, false)
       }
 
       appActions.showNotification({
@@ -503,7 +503,11 @@ function registerPermissionHandler (session, partition) {
         message
       })
 
-      permissionCallbacks[message] = (buttonIndex, persist, index) => {
+      // Use a closure here for the index instead of passing an index to the
+      // function because ipcMain.on(messages.NOTIFICATION_RESPONSE above
+      // calls into the callback without knowing an index.
+      const index = i
+      permissionCallbacks[message] = (buttonIndex, persist) => {
         // hide the notification if this was triggered automatically
         appActions.hideNotification(message)
         const result = !!(buttonIndex)