Upgrade opencv + docker image used for cimbar.js wasm build #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sz3
commented
Oct 21, 2024
sz3
commented
- opencv to 4.10
- pin newer emscripten docker image
- minor tweak to the custom wirehair cmakelists to make sure -march is left off of the wasm build
- might end up turning it off entirely? 🤔
+ also use a newer emscripten docker image.
sz3
commented
Oct 21, 2024
| @@ -54,7 +54,7 @@ set(GEN_TABLES | |||
| gf256.h | |||
| ) | |||
|
|
|||
| if(NOT ANDROID) | |||
| if(NOT ANDROID AND NOT USE_WASM) | |||
| set(ARCH_NATIVE "-march=native") | |||
There was a problem hiding this comment.
The reason for pause I have is that low-power devices (i.e. android phones) are where we'd really benefit from the optimization -- and we're not doing it there anyway. So it might make sense to toss this altogether.
sz3
commented
Oct 21, 2024
| wget https://github.com/opencv/opencv/archive/refs/tags/4.5.5.zip | ||
| unzip 4.5.5.zip | ||
| mv opencv-4.5.5 opencv4 | ||
| wget https://github.com/opencv/opencv/archive/refs/tags/4.10.0.zip |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.