Update dependencies, Fall 2023 edition #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ZSTD_DISABLE_ASM for now (only matters for x64 performance -- I don't think it's worth adding extra build system logic)
We have a scarcity of in-flight bandwidth, and do the compression once at the outset...
sz3
commented
Sep 28, 2023
| @@ -70,7 +70,7 @@ TEST_CASE( "EncoderTest/testFountain.Compress", "[unit]" ) | |||
| Encoder enc(30, 4, 2); | |||
| assertEquals( 1, enc.encode_fountain(inputFile, outPrefix) ); | |||
|
|
|||
| uint64_t hash = 0x4fd34f01ee80a28d; | |||
| uint64_t hash = 0x664598a460acad14; | |||
There was a problem hiding this comment.
Of course, various regression tests broke. 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstd (finally), wirehair, concurrent_queue, fmt, intx. Also includes a change to the default zstd compression level.
16is the highest before real performance drawbacks start to appear. We don't care too much about those performance drawbacks (compression will happen once at the start of an encode), but it also doesn't make sense to crank it to the max and introduce weird startup lag for minimal benefit.OTOH, any compression we can do will speed up overall transfers, so 16 > 6. I think.