css bugfix + package-portable-linux script tweak #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the code show above the background, currently I only see the background but this fixes it
All for 3 words of intro text... But this might be fine?
Why would you make the width >100%. Why
Still probably need an if block
sz3
commented
Jan 21, 2024
| @@ -49,8 +49,7 @@ return { | |||
| { | |||
| // reset zoom | |||
| var canvas = document.getElementById('canvas'); | |||
| canvas.style.zoom = (window.innerWidth / window.outerWidth); | |||
| var width = window.outerWidth; | |||
| var width = window.innerWidth; | |||
There was a problem hiding this comment.
In the process of testing I found a weird interaction with window.outerWidth seemingly being >100% on android firefox? So we'll just use innerWidth...
The goal is to use 100% of the visible viewport, erring on the side of <100% if there's any ambiguity. Note that we're still using outerHeight (not innerHeight) below, so there is room for more rigor here.
Merged
|
Is it live now or do i have to dl the html and run it? |
Not live yet, give it an hour... |
|
Ok, I put it "live" here: https://cimbar.org/beta/ (not on the root cimbar.org yet) |
|
The draft of the release is here: https://github.com/sz3/libcimbar/releases/tag/untagged-b7ec5cbedd11224b3951 |
|
It is working for me
22 Jan 2024 06:42:11 sz3 ***@***.***>:
…
The draft of the release is here: https://github.com/sz3/libcimbar/releases/tag/untagged-b7ec5cbedd11224b3951
—
Reply to this email directly, view it on GitHub[#87 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AWWTZ3MVXAKBTKT6R25UUDDYPYC4HAVCNFSM6AAAAABCEKC2VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTGM2TMMJSHA].
You are receiving this because you commented.
[Tracking image][https://github.com/notifications/beacon/AWWTZ3LTVIYEHVXOGTNDJ23YPYC4HA5CNFSM6AAAAABCEKC2VWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTROLUOA.gif]
|
|
\o/ Great! Thanks for testing! |
|
https://cimbar.org has now been updated with the new css/js. |
|
It turns out it was caused by dark reader addon
23 Jan 2024 06:24:52 sz3 ***@***.***>:
…
\o/
Great! Thanks for testing!
—
Reply to this email directly, view it on GitHub[#87 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AWWTZ3PTLFAKFA56MUNPCJDYP5JTJAVCNFSM6AAAAABCEKC2VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGM3DMOJTGQ].
You are receiving this because you commented.
[Tracking image][https://github.com/notifications/beacon/AWWTZ3NHDPCIWN6EZERTVNTYP5JTJA5CNFSM6AAAAABCEKC2VWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTRSGLZM.gif]
|
sz3
added a commit
that referenced
this pull request
Mar 13, 2024
368c2c4 Merge pull request #90 from sz3/bugfix-santitize-future 258991b Fix some longstanding (no)-fsanitize sloppiness e77b598 Merge pull request #89 from sz3/bugfix-flood-decode-bounds-check ead73ea fix memory corruption bug 0fe367f Fix the error check in FloodDecodePositions 97f4af3 Merge pull request #87 from sz3/build-and-css-bugfix-24-2 0f2d718 Tweak to make package-portable-linux slightly less docker dependent d2ddcc2 Use innerWidth to avert android firefox shenanigans 8f9caa1 If negative z-index is bad vibes, we should set z-index+1 various places 38b8068 Update index.html 0119374 Merge pull request #85 from sz3/pin-cmake-portable-build 452eb71 Pin "portable" linux script to use an old (known good) cmake 05d5e38 Merge pull request #82 from sz3/ios-css-bugfix 69a7d41 Fix bug/change in ios (un)focus behavior? git-subtree-dir: app/src/cpp/libcimbar git-subtree-split: 368c2c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 noted an issue with the negative z-index on Firefox -- perhaps due to some extension. I don't know if a fix is strictly necessary (afaik negative z-index is ok), but in looking at the way the elements are layered I think a bit of reorganization is reasonable.
Also: