Request dual source blending feature during device creation #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jan 23, 2019
webrender/src/device/gfx.rs
Outdated
| .filter(|family| { | ||
| hal::Graphics::supported_by(family.queue_type()) | ||
| && surface.supports_queue_family(&family) | ||
| && 1 <= family.max_queues() |
There was a problem hiding this comment.
we shouldn't have a check for that, IIRC
webrender/src/device/gfx.rs
Outdated
| && surface.supports_queue_family(&family) | ||
| && 1 <= family.max_queues() | ||
| }) | ||
| .next().unwrap(); |
There was a problem hiding this comment.
why is it filter(...).next().unwrap() instead of just find().unwrap()?
There was a problem hiding this comment.
I have used the code of open_with from gfx-rs and I forgot to change the syntax here to match our case. Thanks for the correction.
kvark
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #80 (comment)