Remove barrier transition of frame images #325

zakorgy · 2019-10-21T07:41:08Z

This is a prerequisite of #317.

Made the render pass creation dynamic. Previously we had 4 render passes, but now we moved the transition logic behind render passes so we need to create a variety of them.
Reduced the number of pipeline barriers on frame images. The remaining ones are related to blitting and the read pixel function. To remove these we would need a rebase for the latest WR, because it has solutions which can make this part easier for us.
Started using the clear load operation in places where it's possible.
Added a workaround for debug blits to avoid validation layer errors generated by these calls.

This change is

…relative to, and compute the right transform based on that. r=kats,kvark I think this is as clean as it can get. Differential Revision: https://phabricator.services.mozilla.com/D17848 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/d7a369cd3b4a1df9933fec5e4eba28da8d7745e2

…aster space. r=gw [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/81842621d42775450bb0b27a3dd37642e65b272c

[wrupdater] From servo#3540 Differential Revision: https://phabricator.services.mozilla.com/D18565 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/af2acbe820daaa9ac1b34350bed84d90b1242cf9

Update to have servo/plane-split#27 included Differential Revision: https://phabricator.services.mozilla.com/D18593 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/553538a675ecaf39eebcaf54d6dce1e5d159cca0

…e blur radii. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D17797 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/04def1859392740e18588b52c2c91d38f7bb80a8

Differential Revision: https://phabricator.services.mozilla.com/D17864 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/4eadfbd77cb527918d76dfcfddaa57d9363c486c

Now that we no longer guarantee that a picture with perspective transform is rasterized in local space, we need to ensure that the shaders don't apply perspective correction to the texture coordinates twice. For that to be the case, we pass an extra flag to the plane splitting shader, and un-do the perspective correction if it's not enabled. Differential Revision: https://phabricator.services.mozilla.com/D17854 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/653f85bc0bf8113bb8c0e3d4635412620cfb5857

Calculate the frame_count based on the PresentMode.

Run with "--features=vulkan,headless_gfx" from wrench.

Build as usual. To run wrench in `headless` mode, add `--headless` argument. Eg.: `cargo run --features=vulkan -- --headless reftest`

Previously deleted in servo#319

For the sake of metal backend

kvark

Thank you for the PR!

The most important thing we should keep in mind is render pass compatibility. You have to specify the exact subpass of a render pass when creating a graphics pipeline. The compatibility rules say that you can use that pipeline in any render pass/subpass that is compatible with the one it was created with.

It's mostly the LoadOp and StoreOp that you can change while retaining the compatibility. You can't have a different attachment format, or different layouts... Hence my suggestion to not include the layouts here.

Without the layouts, there aren't many render pass configurations left:

one that doesn't clear, separate for RGBA8 and R8
one that clears the color, separate for RGBA8 and R8
one that clears the color and depth, for RGBA8 only

So we only end up with 5 render passes in total. In which case they don't need to be dynamically created.

kvark · 2019-10-21T18:25:15Z

webrender/src/device/gfx/device.rs

@@ -197,7 +223,8 @@ pub struct Device<B: hal::Backend> {
    staging_buffer_pool: ArrayVec<[BufferPool<B>; FRAME_COUNT_MAILBOX]>,
    pub swap_chain: Option<B::Swapchain>,
    frames: ArrayVec<[Frame<B>; FRAME_COUNT_MAILBOX]>,
-    render_passes: HalRenderPasses<B>,
+    render_pass_manager: RenderPassManager<B>,
+    clear_values: FastHashMap<FBOId, (/*color*/Option<ClearValueRaw>, /*depth*/Option<ClearValueRaw>)>,


let's have a structure defined for the values (better to have fields than comments here:) )

kvark · 2019-10-21T18:31:05Z

webrender/src/device/gfx/render_pass.rs

+#[derive(Copy, Clone, Debug, Hash, Eq, PartialEq)]
+pub(super) struct AttachmentState {
+    pub format: Format,
+    pub src_layout: Layout,


We don't have to put the layout in here. Instead, we can always create the render passes with, say ColorAttachmentOptimal .. ShaderReadOnlyOptimal and then do the transitions outside (using pipeline_barrier) if we need a different layout at the end, or we want to start with a different layout. That would allow us to have much fewer render passes in the end, not to mention the compatibility concerns (to be explained)

zakorgy · 2019-11-21T12:32:47Z

This was implemented in #331

emilio and others added 30 commits February 11, 2019 10:07

Bug 1512010 - snap text positions without device transform in local r…

506ffcc

…aster space. r=gw [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/81842621d42775450bb0b27a3dd37642e65b272c

Bug 1525032 - use switch statement for text snapping decision r=lsalzman

b6f6535

[wrupdater] From servo#3540 Differential Revision: https://phabricator.services.mozilla.com/D18565 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/af2acbe820daaa9ac1b34350bed84d90b1242cf9

Bug 1525087 - Plane split dependency update to 0.13.5 r=kats

7211817

Update to have servo/plane-split#27 included Differential Revision: https://phabricator.services.mozilla.com/D18593 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/553538a675ecaf39eebcaf54d6dce1e5d159cca0

Add gfx backend

ef5baef

Fix deleting in flight textures

f476937

Bug 1523228 - Use down scaling more often to avoid blurs on very larg…

70ac3fc

…e blur radii. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D17797 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/04def1859392740e18588b52c2c91d38f7bb80a8

Bug 1431582 - Add reduced test case for 3d transform bugs. r=kvark

a086afc

Differential Revision: https://phabricator.services.mozilla.com/D17864 [wrupdater] From https://hg.mozilla.org/mozilla-central/rev/4eadfbd77cb527918d76dfcfddaa57d9363c486c

Fix do_debug_blit

c665d78

Apply gecko fixes

856c077

Apply gecko fixes pt2

621d473

Apply gecko fixes pt3

b7d732a

Fix capture and load

1b382c2

Update gfx-rs

ce2a7d2

Store Instance in Device instead of Renderer

e97abba

Wait for pending resources before deiniting device

69a207f

Fix nightly builds

607783f

Update gfx-rs

7c2a9a1

Use PresentMode

4f1f60e

Calculate the frame_count based on the PresentMode.

Fix blitting with different image formats

fd694e3

Use surface format more consistently

357c5da

Better organization of gfx dependencies

a36616d

Add headless mode to gfx-hal backend

9ddc084

Run with "--features=vulkan,headless_gfx" from wrench.

Change headless mode from compile time feature to runtime switch

70222c7

Build as usual. To run wrench in `headless` mode, add `--headless` argument. Eg.: `cargo run --features=vulkan -- --headless reftest`

Update README.md

456efd2

Update gfx-rs

7fa103a

Get max_texture_layers from gfx-hal limits

1e81eaf

Use rendy-memory for memory allocation

12b1172

Fix usage of alignments

516d589

Zakor Gyula and others added 20 commits October 2, 2019 14:05

Encapsulate frame image related resources

cff0d32

Move render passes creation to it's proper place

269f099

Don't start a render pass for each draw

4d40f81

Skip clear rect optimization with gfx-backend

29d0036

Fewer render passes

11e3f61

Fix depth test transitions

00f4c56

Adjust pipeline creation to render pass depth states

d727bce

Delete unnecessary 'push_constans' feature

03f35e4

Add UpdateWindowSize to scene messages

a80bb1b

Remove unused pipeline states

0a4afc5

Restore backend features in example and wrench.

10239f8

Previously deleted in servo#319

Extend image transition

5f29e7a

Merge barriers

57d09e3

Don't store previous state in ImageCore

e62ce37

Fix attachment load ops

c9a99e4

For the sake of metal backend

Fix wrench build on Windows

7942c11

Dynamic render pass creation

a8da8e5

Rework frame image transition

5ccab52

Use clear load operation where it is possible

c960b13

Fix debug blit validation errors

83da150

kvark requested changes Oct 21, 2019

View reviewed changes

kvark mentioned this pull request Oct 24, 2019

Run Gecko with gfx-rs #198

Open

zakorgy force-pushed the master branch 6 times, most recently from 84c0d18 to abc0cd8 Compare November 5, 2019 09:24

zakorgy closed this Nov 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove barrier transition of frame images #325

Remove barrier transition of frame images #325

zakorgy commented Oct 21, 2019 •

edited

Loading

kvark left a comment

kvark Oct 21, 2019

kvark Oct 21, 2019

zakorgy commented Nov 21, 2019

Remove barrier transition of frame images #325

Remove barrier transition of frame images #325

Conversation

zakorgy commented Oct 21, 2019 • edited Loading

kvark left a comment

Choose a reason for hiding this comment

kvark Oct 21, 2019

Choose a reason for hiding this comment

kvark Oct 21, 2019

Choose a reason for hiding this comment

zakorgy commented Nov 21, 2019

zakorgy commented Oct 21, 2019 •

edited

Loading