Support Depth #66
Merged
Support Depth #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dati91
commented
Feb 19, 2018
webrender/src/tiling.rs
Outdated
| @@ -218,8 +218,8 @@ impl<T: RenderTarget> RenderTargetList<T> { | |||
| assert_eq!(t.get_render_target_layer_count(), self.targets.len()); | |||
| assert_eq!(t.get_layer_count() as usize, self.targets.len()); | |||
| //TODO use this | |||
There was a problem hiding this comment.
Note to self: remove this line
Open
zakorgy
reviewed
Feb 20, 2018
webrender/src/device.rs
Outdated
| } | ||
|
|
||
| impl<B: hal::Backend> Depthbuffer<B> { | ||
| pub fn new(device: &B::Device, memory_types: &[hal::MemoryType], pixel_width: u16, pixel_height: u16, depth_format: hal::format::Format) -> Self { |
There was a problem hiding this comment.
Split this parameter list to multiple lines.
webrender/src/device.rs
Outdated
| } | ||
|
|
||
| impl<B: hal::Backend> Framebuffer<B> { | ||
| pub fn new(device: &B::Device, texture: &Texture, image: &Image<B>, layer_index: u16, render_pass: &B::RenderPass) -> Self { | ||
| pub fn new(device: &B::Device, texture: &Texture, image: &Image<B>, layer_index: u16, render_pass: &(B::RenderPass, B::RenderPass), rbo: RBOId, depth: Option<&B::ImageView>) -> Self { |
There was a problem hiding this comment.
Split this parameter list to multiple lines.
webrender/src/device.rs
Outdated
| let pipelines_descriptors = blend_states.iter().map(|blend_state| { | ||
| let pipelines_descriptors = pipeline_states.iter().map(|&(blend_state, depth_test)| { | ||
| let sp = if depth_test == DepthTest::Off { | ||
| subpass |
There was a problem hiding this comment.
Maybe we could construct the required SubPass here like:
let sp = SubPass {
index: 0,
main_pass: if depth_test == DepthTest::Off {&render_pass.0} else {&render_pass.1},
}
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.