-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Depth #66
Support Depth #66
Conversation
webrender/src/tiling.rs
Outdated
@@ -218,8 +218,8 @@ impl<T: RenderTarget> RenderTargetList<T> { | |||
assert_eq!(t.get_render_target_layer_count(), self.targets.len()); | |||
assert_eq!(t.get_layer_count() as usize, self.targets.len()); | |||
//TODO use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: remove this line
webrender/src/device.rs
Outdated
} | ||
|
||
impl<B: hal::Backend> Depthbuffer<B> { | ||
pub fn new(device: &B::Device, memory_types: &[hal::MemoryType], pixel_width: u16, pixel_height: u16, depth_format: hal::format::Format) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split this parameter list to multiple lines.
webrender/src/device.rs
Outdated
} | ||
|
||
impl<B: hal::Backend> Framebuffer<B> { | ||
pub fn new(device: &B::Device, texture: &Texture, image: &Image<B>, layer_index: u16, render_pass: &B::RenderPass) -> Self { | ||
pub fn new(device: &B::Device, texture: &Texture, image: &Image<B>, layer_index: u16, render_pass: &(B::RenderPass, B::RenderPass), rbo: RBOId, depth: Option<&B::ImageView>) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split this parameter list to multiple lines.
webrender/src/device.rs
Outdated
let pipelines_descriptors = blend_states.iter().map(|blend_state| { | ||
let pipelines_descriptors = pipeline_states.iter().map(|&(blend_state, depth_test)| { | ||
let sp = if depth_test == DepthTest::Off { | ||
subpass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could construct the required SubPass here like:
let sp = SubPass {
index: 0,
main_pass: if depth_test == DepthTest::Off {&render_pass.0} else {&render_pass.1},
}
No description provided.