Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle testPlugin deprecation (PIT 1.6.7) #277

Closed
szpak opened this issue Jun 3, 2021 · 4 comments
Closed

Handle testPlugin deprecation (PIT 1.6.7) #277

szpak opened this issue Jun 3, 2021 · 4 comments
Labels
PIT
Milestone
1.7.4

Comments

@szpak
Copy link
Owner

szpak commented Jun 3, 2021

As of 1.6.7 it is no longer used - support for multiple test engines is provided in PIT and there are automatically detected on a classpath.

The parameter should be deprecated (could be still useful for using with lower PIT versions - e.g. for regression testing reasons) and documentation for JUnit 5 plugin support should be revised.
@szpak szpak added the PIT label Jun 3, 2021
@szpak szpak modified the milestones: 1.7.0, 1.7.1 Sep 13, 2021
@szpak
Copy link
Owner Author

szpak commented Sep 19, 2021

Postponed to 1.7.1 to do not confuse people with both JUnit Platform 1.8.0 compatibility and (not related) testPlugin deprecation.

@szpak szpak mentioned this issue Mar 8, 2022
Closed
@szpak
Copy link
Owner Author

szpak commented Mar 8, 2022

Henry kindly reminded about that in #306. The current plan is to release 1.7.1 "soon" and deprecate the testPlugin parameter in the Gradle plugin (to print a warning) and at the same time stop passing it to PIT (to do not generate error with further PIT versions, once it is removed). 1.7.0 will be the minimal required version.

@szpak
Copy link
Owner Author

szpak commented Mar 8, 2022 •
edited
Loading

It suddenly came to me that GPP is usually aware which PIT version is used. As a result, we could just pass the parameter if PIT is <1.7.0 (to keep compatibility with the ower PIT versions - although they shouldn't be used anyway).

This was referenced Mar 8, 2022
Merged
Merged
szpak added a commit that referenced this issue Mar 12, 2022
@szpak
[#277] Do not testPlugins for junit5PluginVersion
bad37db 
For forward compatibility with planned PIT 1.8.0.
szpak added a commit that referenced this issue Mar 12, 2022
@szpak
[#277] Do not set testPlugins for junit5PluginVersion
117d5a8 
For forward compatibility with planned PIT 1.8.0.
szpak added a commit that referenced this issue Mar 12, 2022
@szpak
[#277] "Simplify" test with Groovy magic
09aeb45 
Is it really "simplified"?
@szpak szpak closed this as completed in 0ad82e9 Mar 12, 2022
@szpak szpak modified the milestones: 1.7.5, 1.7.4 Mar 12, 2022
@szpak
Copy link
Owner Author

szpak commented Mar 12, 2022

With just released GPP 1.7.4, --testPlugin should not be send for PIT 1.6.7+.

szpak added a commit to szpak/kotest that referenced this issue Mar 26, 2022
@szpak
Adjust PIT gradle plugin configuration
a4abdaa 
Starting with PIT 1.6.7 it is just enough to have kotest-extensions-pitest on (test) classpath

Over more that parameter is already deprecated and "marked for deletion". See:
hcoles/pitest#900
szpak/gradle-pitest-plugin#277
@szpak szpak mentioned this issue Mar 26, 2022
Merged
sksamuel pushed a commit to kotest/kotest that referenced this issue Mar 27, 2022
@szpak
Adjust PIT gradle plugin configuration (#2903)
3082dc9 
Starting with PIT 1.6.7 it is just enough to have kotest-extensions-pitest on (test) classpath

Over more that parameter is already deprecated and "marked for deletion". See:
hcoles/pitest#900
szpak/gradle-pitest-plugin#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PIT
Projects
None yet
Milestone
1.7.4
Development

No branches or pull requests
1 participant
@szpak