Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run after test task if both should be run #141

Closed
wants to merge 1 commit into from

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Sep 1, 2019

If both should be run, test should be run first.
If --continue is not used and some test fails,
it is better the test task finds this and fails, preventing pitest from being executed.
With the test task you often have better reporting of failed errors.

@szpak
Copy link
Owner

szpak commented Sep 10, 2019

Manually merged and available in 1.4.5. Thanks @Vampire :).

@szpak szpak closed this Sep 10, 2019
@Vampire
Copy link
Contributor Author

Vampire commented Sep 10, 2019

No, it is not, or I'm blind

@Vampire
Copy link
Contributor Author

Vampire commented Sep 10, 2019

No, definitely not in there:

:pitest SKIPPED
:test SKIPPED

@szpak
Copy link
Owner

szpak commented Sep 10, 2019

Commenting, I was thinking about your other PR #137 :).

@szpak szpak reopened this Sep 10, 2019
@szpak szpak added this to the 1.4.6 milestone Sep 10, 2019
szpak added a commit that referenced this pull request Sep 11, 2019
szpak added a commit that referenced this pull request Sep 11, 2019
@szpak
Copy link
Owner

szpak commented Sep 11, 2019

Merged manually.

@szpak szpak closed this Sep 11, 2019
@Vampire Vampire deleted the run-after-test branch May 23, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants