Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for "verbosity" flag, disable spinner by default #321

Merged
merged 4 commits into from
Nov 27, 2022
Merged

add support for "verbosity" flag, disable spinner by default #321

merged 4 commits into from
Nov 27, 2022

Conversation

C-Otto
Copy link
Contributor

@C-Otto C-Otto commented Nov 17, 2022

fixes #267

szpak
szpak requested changes Nov 17, 2022
View reviewed changes
Copy link
Owner

@szpak szpak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! It looks good, however, as you probably noticed, the regression tests detected that "verbosity" is not compatible with old PIT versions (<1.7.1). As it was released in September 2021, it should not be a problem. Just bump the minimal supported version to 1.7.1 (in PitestPluginPitVersionFunctionalSpec - the second constant will be no longer needed) and mention it in the README.

src/test/groovy/info/solidsoft/gradle/pitest/PitestTaskConfigurationSpec.groovy Show resolved Hide resolved
src/main/groovy/info/solidsoft/gradle/pitest/PitestPluginExtension.groovy Outdated Show resolved Hide resolved
@C-Otto
Copy link
Contributor Author

C-Otto commented Nov 18, 2022

I don't really know how to mention the version requirement in the README, feel free to add suggestions! I think we could/should also deprecate verbose in favor of verbosity.

@C-Otto C-Otto requested a review from szpak November 18, 2022 10:04
@szpak
Copy link
Owner

szpak commented Nov 18, 2022

I don't really know how to mention the version requirement in the README, feel free to add suggestions! I think we could/should also deprecate verbose in favor of verbosity.

No problem. I will do it together with the changelog. Thanks for your contribution!

@szpak szpak added this to the 1.9.1 milestone Nov 25, 2022
@szpak szpak merged commit 931f900 into szpak:master Nov 27, 2022
@C-Otto C-Otto deleted the disable-spinner branch November 28, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szpak szpak szpak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.11
Development

Successfully merging this pull request may close these issues.

Ascii art progress indicator messes up Gradle output
2 participants
@C-Otto @szpak