Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#319] Add support for thresholds of aggregated metrics #325

Merged
merged 1 commit into from
Nov 27, 2022
Merged

[#319] Add support for thresholds of aggregated metrics #325

merged 1 commit into from
Nov 27, 2022

Conversation

Pfoerd
Copy link
Contributor

@Pfoerd Pfoerd commented Nov 21, 2022 •
edited
Loading

Fixes #319

@C-Otto
Copy link
Contributor

C-Otto commented Nov 21, 2022

If you use "fixes" instead of "solves", GitHub will automatically link the issue (and close it once this PR is merged).

szpak
szpak approved these changes Nov 21, 2022
View reviewed changes
Copy link
Owner

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. I plan to just do some minor tweaks and merge it in the next "merge window" (hopefully this week).

@szpak szpak added this to the 1.9.1 milestone Nov 25, 2022
szpak added a commit that referenced this pull request Nov 25, 2022
@szpak
[#325][#319] Merge branch 'pr/325' into devel
231b8ad
@szpak szpak merged commit ce904a0 into szpak:master Nov 27, 2022
@Pfoerd Pfoerd mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szpak szpak szpak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.11
Development

Successfully merging this pull request may close these issues.

Add configurable thresholds to report aggregator
3 participants
@Pfoerd @C-Otto @szpak