Skip to content

Commit

Permalink
Refactor JIRA ID extraction pattern
Browse files Browse the repository at this point in the history
Change-Id: I85a458eaac03b2a76edbc2ec923d56467503f900
  • Loading branch information
Villő Szűcs committed Dec 1, 2023
1 parent 0b4f679 commit b9a76f8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions zk-merge-pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ def merge_pr(pr_num, title, pr_repo_desc):
else:
any_in_progress = any(run["status"] == "in_progress" for run in json_status["check_runs"])
if any_in_progress:
continue_maybe("Warning: There are pending checks. Would you like to continue the merge? (y/n): ")
continue_maybe("Warning: There are pending checks. Would you like to continue the merge?")
else:
continue_maybe("Warning: Not all checks have passed on GitHub. Would you like to continue the merge? (y/n): ")
continue_maybe("Warning: Not all checks have passed on GitHub. Would you like to continue the merge?")

headers = {
"Authorization": f"token {GITHUB_OAUTH_KEY}",
Expand Down Expand Up @@ -298,7 +298,7 @@ def get_version_json(version_str):


def resolve_jira_issues(title, merge_branches, comment):
jira_ids = re.findall("%s-[0-9]{4,5}" % CAPITALIZED_PROJECT_NAME, title)
jira_ids = re.findall("%s-[0-9]+" % CAPITALIZED_PROJECT_NAME, title)

if len(jira_ids) == 0:
resolve_jira_issue(merge_branches, comment)
Expand Down

0 comments on commit b9a76f8

Please sign in to comment.