Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd: add hosts max length #38

Merged
merged 1 commit into from
Mar 26, 2024
Merged

crd: add hosts max length #38

merged 1 commit into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. crd: add hosts max length

    controller-gen does not support validating internal list items on list types,
    see kubernetes-sigs/controller-tools#342
    
    To add host pattern we used perl hack that is hard to extend to multiple
    validations.
    
    Also #16 added optional tls spec that contains hosts field for which
    perl hack worked by accident, see #16 (comment)
    
    This change replaces perl hack for a go hack and adds max length constraint.
    
    Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
    AlexanderYastrebov committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d4ea708 View commit details
    Browse the repository at this point in the history