Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First steps #1

Merged
merged 3 commits into from
Jun 5, 2020
Merged

First steps #1

merged 3 commits into from
Jun 5, 2020

Conversation

t-b
Copy link
Owner

@t-b t-b commented May 8, 2020

No description provided.

@t-b t-b mentioned this pull request May 11, 2020
Merged
18 tasks
@NileGraddis NileGraddis mentioned this pull request May 18, 2020
Closed
@t-b t-b force-pushed the first-steps branch 2 times, most recently from 4005758 to 9b4b36f Compare May 19, 2020 22:39
rly
rly reviewed May 19, 2020
View reviewed changes
setup.py Show resolved Hide resolved
rly
rly reviewed May 20, 2020
View reviewed changes
spec/ndx-MIES.extensions.yaml Outdated Show resolved Hide resolved
@t-b
Copy link
Owner Author

t-b commented May 20, 2020

@rly Thanks for the review! Greatly appreciated! I'll incorporate your suggested changes today.

t-b and others added 2 commits May 21, 2020 00:25
@t-b
.gitattributes: Use LF for YAML file EOLs
81d08db
@t-b @rly
Rework extension
2f4bbbd 
- Remove nested type definitions
- Use lower case files as already done in setup.py
- Only use quantity when using the type but not on definition
- Use shape=(Null,) to mean 1D instead of shape=(Null) which means
anything.
- Make nested stimset_referenced_folder work

This is currently not supported by hdmf.

Co-authored-by: Ryan Ly <rly@lbl.gov>
@t-b t-b force-pushed the first-steps branch 2 times, most recently from 9df5848 to 2f4bbbd Compare May 21, 2020 14:22
@t-b t-b merged commit ce4ff33 into master Jun 5, 2020
@t-b t-b deleted the first-steps branch June 5, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-b @rly