Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer disconnected in room pr #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

milochen0418
Copy link

Disconnected Peer will be remove in the peer set (rooms[roomID]) in this PR.
Because the issue 35
#35
We change the output simple-signal-client.js by hand.

@milochen0418
Copy link
Author

@t-mullen
#35 has been solved by this commit a5a84ac
And finally, peer disconnected in the room and switch room can work correctly.

@milochen0418
Copy link
Author

It's look like that peer.on('error') cannot catched all RTCErrorEvent in this case.
Some ERR_DATA_CHANNEL RTCErrorEvent cannot be catched right now,
so just to add how to stop throwing RTCErrorEvent in README and the one who follow this document can make a stable demo.
703016c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant