-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update px unit size for files created by Inkscape >0.92 #347
Comments
Start inkscape0.92 with out loading an svg file, draw some objects, and send to an extension. As an inkscape extension, we cannot know if we should assume 96 or 90 dpi, unless we find a 'sodipodi:docname' element. Looks like a bad inkscape bug to me! |
Parse the inkscape version number from the SVG headers. Then decide for a dpi settings. Next time give me a DPI number right in the document, please!
Parse the inkscape version number from the SVG headers. Then decide for a dpi settings. Next time give me a DPI number right in the document, please!
When investigating #346 it became clear that we're going to have an issue with documents produced by Inkscape 0.92 and later, because the px unit is moving from 90dpi to 96dpi. The original value was due to a typo in the CSS2 standard that was fixed in an errata, but Inkscape used the incorrect value. It's finally been fixed in the development version.
Since Illustrator and other SVG producers use different sizes for the px unit, Visicut tries to determine the creator of an imported file and set the dpi appropriately. We'll soon need to distinguish between SVGs from Inkscape <=0.91 and Inkscape >=0.92 for this to work consistently. Also, the fallback value is 90dpi which seems like it should also be changed to 96 since non-Inkscape producers are more likely to use the latter value than the former.
The text was updated successfully, but these errors were encountered: