Update contributors-data.js

t-will-gillis · Jan 19, 2024 · 83b2814 · 83b2814
1 parent 8b9f3f5
commit 83b2814
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/github-actions/trigger-schedule/github-data/contributors-data.js b/github-actions/trigger-schedule/github-data/contributors-data.js
@@ -276,11 +276,11 @@ async function removeInactiveMembers(currentTeamMembers, recentContributors, ina
           role: 'member',
         })
       } 
-      if(username in inactiveWithOpenIssue){
-        cannotRemoveYet[username] = inactiveWithOpenIssue[username];
-      } else {
-        // Remove contributor from a team if they don't pass additional checks in `shouldRemoveOrNotify` function
-        if(await shouldRemoveOrNotify(username)){   
+      // Remove contributor from a team if they don't pass additional checks in `shouldRemoveOrNotify` function
+      if(await shouldRemoveOrNotify(username)){
+        if(username in inactiveWithOpenIssue){
+          cannotRemoveYet[username] = inactiveWithOpenIssue[username];
+        } else {
           // await octokit.request('DELETE /orgs/{org}/teams/{team_slug}/memberships/{username}', {
           //   org: org,
           //   team_slug: team,
@@ -289,8 +289,7 @@ async function removeInactiveMembers(currentTeamMembers, recentContributors, ina
           console.log("Would be deleted: " + username);
           removedMembers.push(username);
         }
-        // removedMembers.push(username);
-      }
+      } 
     }
   }
   return [removedMembers, cannotRemoveYet];