Update check-label-preliminary-update.js

t-will-gillis · Dec 29, 2023 · d18335e · d18335e
1 parent d80e936
commit d18335e
Showing 1 changed file with 30 additions and 20 deletions.
diff --git a/github-actions/trigger-issue/add-preliminary-comment/check-label-preliminary-update.js b/github-actions/trigger-issue/add-preliminary-comment/check-label-preliminary-update.js
@@ -41,29 +41,39 @@ function obtainLabels(){
  * @returns - A boolean which tells whether we are supposed to post a preliminary update based on the given issue checks
  */
 
-function postComment(existingLabels){
-    //issue states that we are to post the comment if--> there is a role: back end/devOps tag...(continued on next comment)
-    if(existingLabels.includes("role: back end/devOps")){
-        return true
-    }
+// function postComment(existingLabels){
+//     //issue states that we are to post the comment if--> there is a role: back end/devOps tag...(continued on next comment)
+//     if(existingLabels.includes("role: back end/devOps")){
+//         return true
+//     }
+
+//     // or if there is a role: front end tag
+//     else if(existingLabels.includes("role: front end")){
+//         return true
+//     }
 
-    // or if there is a role: front end tag
-    else if(existingLabels.includes("role: front end")){
-        return true
-    }
+//     //or if there is a role: design tag
+//     else if(existingLabels.includes("role: design")){
+//         return true
+//     }
 
-    //or if there is a role: design tag
-    else if(existingLabels.includes("role: design")){
-        return true
-    }
+//     //or if there is a role: user research
+//     else if(existingLabels.includes("role: user research")){
+//         return true
+//     }
 
-    //or if there is a role: user research
-    else if(existingLabels.includes("role: user research")){
-        return true
-    }
+//     //otherwise we return a false
+//     return false
+// }
+
+// Simplify postComment()
+function postComment(existingLabels){
+    // Post the comment if there is a role: back end/devOps tag...(continued on next comment)
+    const labelsThatTriggerComments = ["role: back end/devOps", "role: front end", "role: design", "role: user research"]
+    console.log('in add-preliminary-comment.js')
+    console.log(existingLabels.some(value => labelsThatTriggerComments.includes(value)));
+    return existingLabels.some(value => labelsThatTriggerComments.includes(value));
 
-    //otherwise we return a false
-    return false
 }
 
-module.exports = main
+module.exports = main