Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Convert generated eslintrc file from JSON to CJS #1218

Merged
merged 6 commits into from
Feb 19, 2023
Merged

feat: Convert generated eslintrc file from JSON to CJS #1218

merged 6 commits into from
Feb 19, 2023

Conversation

bai
Copy link
Contributor

@bai bai commented Feb 19, 2023

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Rename generated .eslintrc.json to .eslintrc.cjs and enable type-checking vis JSDoc.

💯

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2023

🦋 Changeset detected

Latest commit: fb3682a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 11:08AM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation labels Feb 19, 2023
@github-actions
Copy link
Contributor

Running Lighthouse audit...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2023

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

AR: @a4addel, @Sboonny | ES: | FR: @Defranos, @joachimjusth | NO: @estubmo, @josephayman | PL: @matibox, @Infiplaya, @PiotrekPKP | PT: @minsk-dev, @Sn0wye, @victoriaquasar, @MattFerreira18, @gilhrpenner | RU: @AmadeusTwi, @ronanru, @JohnBakhmat | ZH-HANS: @fernandoxu, @lodisy

@JohnBakhmat
Copy link
Contributor

LGTM ;)

@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 19, 2023
Merged via the queue into t3-oss:next with commit 4f8d41a Feb 19, 2023
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* Convert generated eslintrc file to CJS

* Create chilled-feet-wait.md

* fix

* restore

* fix changeset

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants