feat: Replace Git Bash check with Mintty check #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iAverages
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
🦋 Changeset detectedLatest commit: f404347 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
|
Can you test this on windows @nexxeln |
|
Works! I'm not sure about the two warnings though. |
|
Yea I don’t like the two warnings however I feel like we would get lots of questions about Git Bash not working (with mintty). since mintty is installed by default with Git Bash. I can remove the second warning and potentially change the first message though not sure what the best option is. |
c-ehrlich
reviewed
Mar 25, 2023
juliusmarminge
approved these changes
Mar 26, 2023
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
* Replace gitbash check with mintty check * Fix spacing of message * Add changeset * Change warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1281
✅ Checklist
Changelog
Replaced the Git Bash check if a check for Mintty. Git Bash works perfectly fine when using another terminal. Mintty is the issue here and it causes lots of issues with other CLI programs.
Not too sure if we want two messages here, I think having a notice specific to Git Bash is needed as it is mainly Git Bash users who are having this issue (Since Git Bash uses Mintty by default).
Screenshots
WSL VSC (Should not be affected by the change)
Git Bash + Mintty
Git Bash + Windows Terminal
💯