Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for using bun package manager (bunx / bun install) #1375

Merged
merged 10 commits into from
Aug 27, 2023
Merged

feat: Add support for using bun package manager (bunx / bun install) #1375

merged 10 commits into from
Aug 27, 2023

Conversation

Zeko369
Copy link
Contributor

@Zeko369 Zeko369 commented Apr 22, 2023

Closes #1366

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Add case to detect if the CLI was ran via bunx and use bun install in that case

Screenshots

bun install goes brrrrrrrrr 🚀🚀🚀🚀

Speeeeed

💯

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 21bd8c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2023 7:54pm

@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Apr 22, 2023
@github-actions
Copy link
Contributor

Running Lighthouse audit...

@juliusmarminge
Copy link
Member

Should we add CI for this?

@FleetAdmiralJakob
Copy link

Any updates on this?

@vercel
Copy link

vercel bot commented Aug 27, 2023

@juliusmarminge is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 📌 area: ci Relates to CI / GitHub Actions label Aug 27, 2023
@juliusmarminge
Copy link
Member

Did you delete your fork or something? I can't seem to push anymore...

@Zeko369
Copy link
Contributor Author

Zeko369 commented Aug 27, 2023

No 🤔, you should have permissions? Do you want to me to manually invite you to make sure?

@juliusmarminge
Copy link
Member

Nvm i was in the wrong directory lmaoo

@juliusmarminge juliusmarminge marked this pull request as ready for review August 27, 2023 19:33
juliusmarminge
juliusmarminge approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliusmarminge juliusmarminge added this pull request to the merge queue Aug 27, 2023
@juliusmarminge juliusmarminge removed this pull request from the merge queue due to a manual request Aug 27, 2023
@juliusmarminge juliusmarminge added this pull request to the merge queue Aug 27, 2023
@juliusmarminge
Copy link
Member

Tested on create-t3-app@7.19.0-alpha-bun.1

@juliusmarminge juliusmarminge removed this pull request from the merge queue due to a manual request Aug 27, 2023
@github-actions
Copy link
Contributor

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

AR: @a4addel, @Sboonny | ES: | FR: @Defranos, @joachimjusth, @vdeva | JA: @t6adev, @uehaj | NO: @estubmo, @josephayman | PL: @matibox, @Infiplaya, @PiotrekPKP | PT: @minsk-dev, @Sn0wye, @victoriaquasar, @MattFerreira18, @gilhrpenner | RU: @AmadeusTwi, @ronanru, @JohnBakhmat | ZH-HANS: @fernandoxu, @escwxyz

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Aug 27, 2023
@juliusmarminge juliusmarminge merged commit d781f08 into t3-oss:next Aug 27, 2023
25 checks passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2023
Merged
@juliusmarminge
Copy link
Member

Released in 7.19

devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@Zeko369 @juliusmarminge
feat: Add support for using bun package manager (bunx / bun install) (t…
db3496f 
…3-oss#1375)

* Detect and run install with bun if using bunx to call ct3a

* format

* add CI

* fix dev script in next-steps

* alter ci

* fix path

* lint

* changeset

* doc

---------

Co-authored-by: juliusmarminge <julius0216@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich

Assignees
No one assigned
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support initializing with Bun
3 participants
@Zeko369 @juliusmarminge @FleetAdmiralJakob