Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next 15 + Repo refresh #2004

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Next 15 + Repo refresh #2004

wants to merge 15 commits into from

Conversation

ahkhanjani
Copy link
Contributor

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4624a97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:19am

@vercel Vercel
Copy link

vercel bot commented Oct 27, 2024

@ahkhanjani is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@ahkhanjani
Copy link
Contributor Author

ahkhanjani commented Oct 27, 2024 •
edited
Loading

Still working on it.

EDIT: Might end up having to split this into multiple PRs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 27, 2024 •
edited
Loading

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

@ahkhanjani
Copy link
Contributor Author

I need help with the repo's linting as running pnpm lint keeps hanging. I suspect it's because each project now requires its own eslint.config.js if we want a lint script for each one but I'm not sure.

@ahkhanjani
Copy link
Contributor Author

@juliusmarminge would you kindly review + help with linting (since it's opinionated). I think we're mostly finished here.

ahkhanjani
ahkhanjani commented Oct 31, 2024
View reviewed changes
www/astro.config.ts
import { defineConfig } from "astro/config";
import rehypeAutolinkHeadings from "rehype-autolink-headings";
import rehypeExternalLinks from "rehype-external-links";
import rehypeSlug from "rehype-slug";
import remarkCodeTitles from "remark-code-titles";
import remarkCodeTitle from "remark-code-title";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this package because the new one has type defs and is newer and is based on the previous one but I haven't tested its functionality. If problems occur I'll revert it and @ts-ignore it.

@juliusmarminge
Copy link
Member

@juliusmarminge would you kindly review + help with linting (since it's opinionated). I think we're mostly finished here.

so this is making changes both to the CLI and the overall repo? any chance you could split it to 2 ? 1 for the repo refresh and 1 for the CLI updates?

@ahkhanjani
Copy link
Contributor Author

so this is making changes both to the CLI and the overall repo? any chance you could split it to 2 ? 1 for the repo refresh and 1 for the CLI updates?

I could probably make it into even more PRs for the docs and update projects and eslint v9 depending on how integrated they are

@codefromhimanshu
Copy link

Is it adding support for the upgrading existing t3 app to next15

@ahkhanjani
Copy link
Contributor Author

Is it adding support for the upgrading existing t3 app to next15

Hi. We've decided to split this PR into multiple PRs such as #2007 and more coming after. You can see the changes and upgrade your existing project manually. There is no automatic migration if that's what you're asking.

I suggest you wait until #2007 merges. Then create a new project and compare the changes and migrate accordingly.

@ahkhanjani ahkhanjani marked this pull request as draft November 11, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge juliusmarminge is a code owner

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich c-ehrlich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahkhanjani @juliusmarminge @codefromhimanshu