Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing next-auth types #255

Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix: missing next-auth types #255

merged 1 commit into from
Jul 26, 2022

Conversation

zomars
Copy link
Contributor

@zomars zomars commented Jul 26, 2022 •
edited
Loading

Fixes missing type in next-auth module augmentation.

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

fixes #254 Fixes missing type in next-auth module augmentation.

Screenshots

[Screenshots]

image

@zomars zomars changed the title Fixes #254 fix: missing next-auth types Jul 26, 2022
@nexxeln
Copy link
Member

nexxeln commented Jul 26, 2022

I'm unable to reproduce the bug, let's talk in the issue first

nexxeln
nexxeln reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, are you sure next-auth/core/types is the correct file?

@nexxeln
Copy link
Member

nexxeln commented Jul 26, 2022

Just checked the next-auth repo, looks good.

@nexxeln nexxeln merged commit ed42629 into t3-oss:main Jul 26, 2022
@zomars
Copy link
Contributor Author

zomars commented Jul 26, 2022

Thanks, are you sure next-auth/core/types is the correct file?

yup

image

image

@zomars zomars deleted the patch-1 branch July 26, 2022 03:10
@zomars zomars mentioned this pull request Jul 26, 2022
Closed
@juliusmarminge juliusmarminge mentioned this pull request Jul 26, 2022
Merged
3 tasks
juliusmarminge added a commit that referenced this pull request Aug 16, 2022
@juliusmarminge @ochicf
@danielroe @jln13x @HaukeSchnau @amyisdev @c-ehrlich @nexxeln @nramkissoon @bhatvikrant @gcavanunez @abui-am @JohnDaly @Duckapple @fernandoxu @zomars @Krish120003 @cyremur @Samathingamajig @khalil-omer @BWsix @github-actions @kroucher
refactor: merge monorepo into next (#322)
d960c36 
* chore(docs): updated readme to contain @next

* refactor: inject curried `runPkgManagerInstall` to package installers (#202)

* refactor: export curryable `runPkgManagerInstallOptions`

* refactor: inject curried `runPkgManagerInstall` to installers

* refactor: use curried function in installers

* fix: refactored calls that should have passed `devMode` flag

* fix: typo

* feat: migrate env + next config to esm (#205)

* chore: move lintstaged config into file (#217)

* fix: move gitignore rename call (#215)

* feat: add trpc inference helpers

* fix(#218): lock react-query to v3

* chore(release): 5.1.0

* fix: add missing trpc import

* chore(release): 5.1.1

* fix: handle pkg with version in noInstall mode (#220)

* fix: typo in readme

* feat: add db.sqlite-journal to gitignore (#221)

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

* fix: typo - rename 'varibles' to 'variables' (#223)

* fix: missing DATABASE_URL (#222)

* chore(release): 5.2.0

* fix: update url in auth prisma schema

* chore(release): 5.2.1

* feat: add typesafe client side env variables (#209)

* feat: add typesafe client side env variables

* refactor: clean up type-safe client side env vars

* fix: add inferProcedureInput/Output imports in trpc utils

* refactor: client env validation

* refactor: run prettier

* refactor: clean up files and formatter func

* fix: validate public env vars are not in server schema

* fix: add ts-check to mjs files

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

* fix: title being offset when using yarn/pnpm

* chore(release): bump beta version

* chore: bump Next.js to 12.2.3

* chore(release): bump beta version

* feat: improved logo typography (#238)

* chore: bump beta version

* fix: remove semicolon in _app.tsx with next-auth to avoid early return

* chore: bump beta version

* chore: add protected trpc router example (#194)

* chore: add link to community (#229)

* chore: add link to community info

* chore: add discord badge

* fix: t3 discord id

* fix: discord link on badge

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

* docs(readme): add usage for beta and next version (#243)

* chore: add js files to format script (#244)

* chore: remove credentials provider (#246)

* refactor(cli): add module path aliasing (#247)

* feat: updating tailwind and postcss config's to use .cjs (#242)

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>

* fix: clarify some comments and rename some files in env (#245)

* fix: clarify some comments and rename some files in env

* fix: filenames in installer

* fix: import in next.config

* fix: import after filechange

* fix: forgotten rename

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

* chore(release): bump beta version

* fix: added JSDoc type to clientEnv in all env-schema (#240)

* chore(release): 5.3.0

* refactor(utils): remove unnecessary block (#252)

* chore: update favicon (#253)

* fix: missing next-auth types (#255)

fixes #254

* fix: height on small screens (#256)

* docs: expand t3-app README (#248)

* revert: extend regular next-auth module (#257)

* revert: extend regular next-auth module

* refactor: move typedefs to `src/types`

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

* feat: add deployment strategy to generated README (#258)

* fix(docs): remove extra s in link

* feat: add deployment strategy to readme

* docs: add instructions on building docker image to readme (#265)

* Add instructions on building docker image

Following the same method given in NextJs examples

* fix: prettier check

run prettier format to fix formatting issues

* docs: small adjustments (#266)

* docs: add instructions on building docker image to readme (#265)

* Add instructions on building docker image

Following the same method given in NextJs examples

* fix: prettier check

run prettier format to fix formatting issues

* docs: small adjustments

* feat: set appName to directory on 'npx create-t3-app .' (#273)

* fix(prisma): make db changes for next-auth on mysql obvious (#275)

* chore(release): 5.4.0

* feat: make session.user.id non-nullable (#282)

* chore(release): 5.5.0

* docs: update tRPC v10 docs link (#291)

* fix: change ! reversion to equality in env validation (#293)

* feat: Include ct3a version as metadata in generated app (#305)

* fix: parse path returned from process.cwd() before using it (#303)

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* chore(release): 5.6.0

* chore: upload T3 logo to github (#311)

* chore: upload T3 logo to github

* chore: format

* chore: ignore package-lock (#315)

* chore: Publish Workflow and other Github enhancements (#308)

* chore: switch standard-version to changeset

* chore: add version workflow

* chore: issue forms and pr labeler

* chore: prettier

* chore: add missing credit

* chore: adjust some commands

* chore: update contributing guidelines

* chore: prettier

* chore: adjustments

* feat: add minimal ts-linter

* fix: lint warnings

* revert eslinter

* chore(ci): dont use reserved word `package`

* chore(ci): require -> import

* chore(ci): authenticate to npm

* chore: update pr-template

* chore(ci): next-release

* chore(ci): release workflow

* chore(ci): update scrips

* chore(ci): update release versioning

* chore(ci): update versioning scripts

* chore(ci): fix no-bin error

* feat: add base tslint (#317)

* chore(app): version bumps

* feat: add base linter for ts

* fix: test ignoring base

* fix: test setting root

* fix: test add parser

* fix: test disabling exclude

* chore: changeset

* chore(ci): test changeset with npx

* chore(ci): test npm

* chore(ci): give proper commit message and title

* chore(release): remove standard-version msg from changelog

* chore(release): version packages (#319)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(release): public access

* refactor: turborepo with cli and www (#320)

* docs: add docs site built with Astro (#300)

* docs: add docs site built with Astro

* docs: prettier

Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>

* refactor: make monorepo

* chore(fix): tailwindcss/typography peer deps

* refactor: docusaurus migration

* docs: styling

* fix: linting

* fix: typecheck

* fix: no typecheck www

* fix: restore tsconfig

* fix(ci): cache all node_modules

* fix: more caching

* fix: missing lint plugin

* fix(ci): cwd

* fix(ci): path

* docs: start on collection

* docs: headers

Co-authored-by: Kroucher <99768034+kroucher@users.noreply.github.com>
Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: sir-mr-bean <kroucher.1019@gmail.com>

* chore: set type module

* fix: typo in pub-script

* fix: create npmrc in cli pkg

* fix: path in version script

* refactor: turborepo next

Co-authored-by: Oscar Chic <oscarchicfarre@gmail.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: JLN13X <85513960+JLN13X@users.noreply.github.com>
Co-authored-by: Hauke Schnau <31801906+HaukeSchnau@users.noreply.github.com>
Co-authored-by: Azmi Makarima <94958349+amyisdev@users.noreply.github.com>
Co-authored-by: Christopher Ehrlich <ehrlich.christopher@gmail.com>
Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: Nicholas Ramkissoon <nicholas.ramkissoon01@gmail.com>
Co-authored-by: Vikrant Bhat <50735025+bhatvikrant@users.noreply.github.com>
Co-authored-by: Guillermo Antony Cava Nuñez <gcavanunez@gmail.com>
Co-authored-by: Abui <adjiem31@gmail.com>
Co-authored-by: John Daly <john.daly2@gmail.com>
Co-authored-by: Simon Green Kristensen <github@simon-green.dev>
Co-authored-by: XLS <fernandoxu9@gmail.com>
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: Krish <52761222+Krish120003@users.noreply.github.com>
Co-authored-by: cyremur <cyremur@users.noreply.github.com>
Co-authored-by: Samuel Gunter <samuelgunter3@gmail.com>
Co-authored-by: Khalil Omer <68179593+khalil-omer@users.noreply.github.com>
Co-authored-by: BWsix <itisbw62@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kroucher <99768034+kroucher@users.noreply.github.com>
Co-authored-by: sir-mr-bean <kroucher.1019@gmail.com>
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@zomars
fix: missing next-auth types (t3-oss#255)
b83f032 
fixes t3-oss#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexxeln nexxeln nexxeln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding "paths" and "baseUrl" to tsconfig.json breaks module augmentations
2 participants
@zomars @nexxeln