Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor improvements #417

Closed
wants to merge 13 commits into from
Closed

docs: minor improvements #417

wants to merge 13 commits into from

Conversation

rhenriquez28
Copy link
Contributor

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-08-15).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Wanted to contribute to the new docs and here are some improvements I did. Mostly to do with styling.

  • Fixed search bar and "On this page" text styles when in light mode
  • Added sticky behavior to the sidebars when reading the docs
  • Modified "More" text style on right sidebar to be consistent with "On this page" text style
  • Added a little more spacing to the headers in left sidebar
  • Removed weird behavior where the page would scroll to the top when the user toggled between light theme and dark theme

Screenshots

Since the most important changes are visual, I thought I would share some videos instead. You can also feel free to compare with the Preview URLs from Vercel to try out the improvements.

Current styles without sticky sidebars and weird scroll theme toggle behavior

New styles with sticky sidebars and improved theme toggle behavior

💯

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

🦋 Changeset detected

Latest commit: 66fe37e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Sep 10, 2022 at 2:21PM (UTC)

@rhenriquez28
Copy link
Contributor Author

I just realized that the previous changes I did in my last contribution were added here. Should I just delete the changeset or is there something else that I need to do here to remove the last contribution from this PR?

@nexxeln
Copy link
Member

nexxeln commented Sep 10, 2022

I just realized that the previous changes I did in my last contribution were added here. Should I just delete the changeset or is there something else that I need to do here to remove the last contribution from this PR?

I would prefer if you create a new branch and make the PR from there.

Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thank you!

@nexxeln nexxeln closed this Sep 10, 2022
@nexxeln
Copy link
Member

nexxeln commented Sep 10, 2022

This PR was redone in #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants