Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Update-dockerfile to resolve prisma bug #970

Merged
merged 1 commit into from
Dec 13, 2022
Merged

fix(docs): Update-dockerfile to resolve prisma bug #970

merged 1 commit into from
Dec 13, 2022

Conversation

AnthonyPoschen
Copy link
Contributor

prisma compiling in a dockerfile has stopped working as per prisma/prisma#14073 and a resolution has been posted, so for now might be a good idea to ensure the website documentation works for dockerfiles

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

applied patch to ensure dockerfile building works again

Screenshots

image

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

⚠️ No Changeset found

Latest commit: 05dddd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 2:27PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Dec 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-anthonyposchen-next-t3-oss.vercel.app/

@AnthonyPoschen AnthonyPoschen changed the title Update dockerfile to resolve prisma bug fix(docs): Update-dockerfile to resolve prisma bug Dec 13, 2022
c-ehrlich
c-ehrlich approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR :)

I think someone else on Discord already had this problem recently and didn't find a solution

@c-ehrlich c-ehrlich merged commit b5bd7d9 into t3-oss:next Dec 13, 2022
This was referenced Dec 13, 2022
Closed
Merged
Closed
Closed
Open
Closed
Merged
Merged
joachimjusth added a commit to joachimjusth/create-t3-app that referenced this pull request Dec 14, 2022
@joachimjusth
docs: update deployment/docker.md with updated documentation coming f…
30190a0 
…rom PR t3-oss#970
c-ehrlich added a commit that referenced this pull request Dec 22, 2022
@joachimjusth @c-ehrlich @Defranos
docs: french translation (#938)
2c30a10 
* docs: starting work on french translation

* docs: translate deployment/docker.md to french

* docs: translate deployment/vercel.md to french

* docs: translate usage/env-variables.md

* docs: usage/first-steps.md

* docs: usage/next-js.md

* docs: usage/typescript.md

* docs: usage/prisma.md

* docs: usage/tailwind.md

* docs: usage/next-auth.md

* docs: update deployment/docker.md with updated documentation coming from PR #970

* docs: translate usage/trpc.md to french

* docs: translate faq.md to french

* docs: update usage/trpc.md in french with #960

* docs: translate t3-collection.md to french

* docs: translate installation.md to french

* docs: translate introduction.md to french

* docs: erratum in t3-collection.md

* docs: erratum in introduction.md

* docs: translate why.md to french

* docs: translate other-recs.md to french

* docs: translate folder-structure.md to french

* docs: fix typo in next-auth.md (french)

* docs: fix wording and typo in few files (french)

* docs: enable french on the website

* docs: translate deployment/netlify.md to french

* docs: update folder-structure to mdx (french)

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/index.astro

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/usage/trpc.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/usage/trpc.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Apply suggestions from code review

Change some wordings

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Apply suggestions from code review

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Apply suggestions from code review

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: update fr/deployment/index.astro

Fix linting issue on fr/deployment/index.astro

* docs: revert change on fr/deployment/index.astro

* docs: update fr/usage/index.astro

* docs: update fr/deployment/index.astro

* docs: Apply suggestions from code review

Co-authored-by: Defranos <vincent.guirou@gmail.com>

Co-authored-by: Christopher Ehrlich <ehrlich.christopher@gmail.com>
Co-authored-by: Joachim Justh <joachim.justh@alithya.com>
Co-authored-by: Defranos <vincent.guirou@gmail.com>
@JohnBakhmat JohnBakhmat mentioned this pull request Dec 26, 2022
Merged
3 tasks
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@AnthonyPoschen
Update dockerfile to resolve prisma bug (t3-oss#970)
a064104
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@joachimjusth @c-ehrlich @Defranos
docs: french translation (t3-oss#938)
24278cc 
* docs: starting work on french translation

* docs: translate deployment/docker.md to french

* docs: translate deployment/vercel.md to french

* docs: translate usage/env-variables.md

* docs: usage/first-steps.md

* docs: usage/next-js.md

* docs: usage/typescript.md

* docs: usage/prisma.md

* docs: usage/tailwind.md

* docs: usage/next-auth.md

* docs: update deployment/docker.md with updated documentation coming from PR t3-oss#970

* docs: translate usage/trpc.md to french

* docs: translate faq.md to french

* docs: update usage/trpc.md in french with t3-oss#960

* docs: translate t3-collection.md to french

* docs: translate installation.md to french

* docs: translate introduction.md to french

* docs: erratum in t3-collection.md

* docs: erratum in introduction.md

* docs: translate why.md to french

* docs: translate other-recs.md to french

* docs: translate folder-structure.md to french

* docs: fix typo in next-auth.md (french)

* docs: fix wording and typo in few files (french)

* docs: enable french on the website

* docs: translate deployment/netlify.md to french

* docs: update folder-structure to mdx (french)

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/docker.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/deployment/index.astro

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/usage/trpc.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Update fr/usage/trpc.md

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Apply suggestions from code review

Change some wordings

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Apply suggestions from code review

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: Apply suggestions from code review

Co-authored-by: Defranos <vincent.guirou@gmail.com>

* docs: update fr/deployment/index.astro

Fix linting issue on fr/deployment/index.astro

* docs: revert change on fr/deployment/index.astro

* docs: update fr/usage/index.astro

* docs: update fr/deployment/index.astro

* docs: Apply suggestions from code review

Co-authored-by: Defranos <vincent.guirou@gmail.com>

Co-authored-by: Christopher Ehrlich <ehrlich.christopher@gmail.com>
Co-authored-by: Joachim Justh <joachim.justh@alithya.com>
Co-authored-by: Defranos <vincent.guirou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyPoschen @c-ehrlich