Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas about pnpm catalog protocol #1237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ahkhanjani
Copy link
Contributor

Treat this as a proposal. What are your opinions on this?

  • Use YAML's anchors/references for namespace packages that must use the same version period (could include turbo as well).
  • Add the frequently used @types/node using only the major version. Could also be sepcified as 20.x.

Comment on lines +8 to +10
"@trpc/client": &trpcVersion ^11.0.0-rc.601
"@trpc/react-query": *trpcVersion
"@trpc/server": *trpcVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh idk... i get the idea but it just looks weird... i prefer just separating groups with a newline or something to make it clear they're related?

Copy link
Contributor Author

@ahkhanjani ahkhanjani Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh idk... i get the idea but it just looks weird... i prefer just separating groups with a newline or something to make it clear they're related?

Something like this?

catalog:
  # types
  "@types/node": "20"
  # tooling
  eslint: ^9.13.0
  prettier: ^3.3.3
  tailwindcss: ^3.4.14
  typescript: ^5.6.3
  # trpc
  "@trpc/client": ^11.0.0-rc.601
  "@trpc/react-query": ^11.0.0-rc.601
  "@trpc/server": ^11.0.0-rc.601
  # rest
  "@tanstack/react-query": ^5.59.16
  zod: ^3.23.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants