Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new info state and screen to splash mode #181

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

t3knomanzer
Copy link
Owner

@t3knomanzer t3knomanzer commented Sep 9, 2020

Issues

Description

I made the splash screen into a new mode with multiple screens that you can cycle through by tapping like any other mode. Currently there are 2 states, logo and info.
I added the "info" screen which at the moment just displays the firmware version.
Created a version define that we can override at compile time in the build process to use the actual release version.

Disclaimer
I had to use 3 separate defines for major, minor and patch instead of a string because the arduino-cli does not support string type defines due to a bug (arduino/arduino-cli#846 (comment))

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Requested changes are in a branch
  • Compiled and tested requested changes on target hardware (PC, device)
  • Updated the documentation, if necessary
  • Updated the LICENSES file, if necessary
  • Reviewed the guidelines for contributing to this repository

@quadbyte
Copy link
Collaborator

quadbyte commented Sep 9, 2020

Added build date below the firmware version

Added built date below the firmware version
@t3knomanzer t3knomanzer merged commit 8d7fd4e into master Sep 9, 2020
@t3knomanzer t3knomanzer deleted the splash-info-screen branch September 9, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show firmware version in device
3 participants