Adding new info state and screen to splash mode #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
I made the splash screen into a new mode with multiple screens that you can cycle through by tapping like any other mode. Currently there are 2 states, logo and info.
I added the "info" screen which at the moment just displays the firmware version.
Created a version define that we can override at compile time in the build process to use the actual release version.
Disclaimer
I had to use 3 separate defines for major, minor and patch instead of a string because the arduino-cli does not support string type defines due to a bug (arduino/arduino-cli#846 (comment))
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.