Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❓ add CSS selector tests for the argument operator #762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bronson
Copy link
Contributor

@bronson bronson commented Apr 20, 2017

Minor feature request... What do you think of making the comma operator work on CSS selectors? Like the first line here:

atom-text-editor .wrap-guide, :host .wrap-guide {
  color: @syntax-wrap-guide-color;
}

I included some tests to demonstrate what I was thinking. (& I don't expect you to merge them broken like this)

I'd expect, if the line includes a comma, regardless of surrounding parentheses, then use comma as a separator.

@bronson bronson force-pushed the comma-operator-on-css-selectors branch from a22035a to d65849e Compare April 20, 2017 21:54
This is just an example, they don't work yet.
@bronson bronson force-pushed the comma-operator-on-css-selectors branch from d65849e to fa5d1ba Compare April 20, 2017 21:55
@t9md
Copy link
Owner

t9md commented Apr 21, 2017

bulk-change-to-double-quote

I got your request, and understood what you want to do from spec.
But need some thinking,

  • This new enhancement conflict the above gif where I can't simply split by comma(see when keyword in ruby file NOT treated as argument in spite of when is left-side of comma).
  • So we have to make arguments text-object further intelligent.

Btw, I want to make argument text-object(not operator!) further intelligent.

  • To less incorrect select
  • To work on space separated arguments more correctly.
  • To work for what user most expect based on context basically.

I love argument text-object and want to use more, so will work on that soon.

@sefabey
Copy link

sefabey commented Nov 22, 2017

Got a very simple question for t9m9. How do you turn on commands popup as in the GIF? As a noob, would be useful for me.

@t9md
Copy link
Owner

t9md commented Nov 22, 2017

Install demo-mode package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants