Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Missing or incorrect names #2

Closed
cubedsphered opened this issue Dec 6, 2022 · 9 comments
Closed

Missing or incorrect names #2

cubedsphered opened this issue Dec 6, 2022 · 9 comments
Assignees

Comments

@cubedsphered
Copy link

cubedsphered commented Dec 6, 2022

I've noticed many of the lobbies I'm in, the tool detects 4 names (1 missing) or displays the incorrect name. I'm thinking this might be because of the code picking up Riot ID instead of Summoner ID/Name. Works as intended for majority of players, this is the exclusion. well done

@cubedsphered
Copy link
Author

I should mention, in most cases, the player will have Riot ID same as Summoner Name, however, many Valorant players will have changed their Riot ID to something different than their League name.

@tGecko
Copy link
Owner

tGecko commented Dec 6, 2022

Thank you very much, I think I identified the issue (I'm using the field "game_name" instead of just "name") and will fix this ASAP (next 2 hours)

EDIT: I kinda saw this coming as I saw the 2 fields name and game_name and in my tests they always were the same. Seems I got unlucky when testing.

@tGecko tGecko self-assigned this Dec 6, 2022
tGecko pushed a commit that referenced this issue Dec 6, 2022
@tGecko
Copy link
Owner

tGecko commented Dec 6, 2022

Kindly test Release 1.3.
If you could report back it'd help me very much.

@kartoffelsaretasty
Copy link

It works a lot better now, only very rarely it doesn't return a valid summoner (but in the 2 occasions that happened, the summoner was equal to what the program returned, just not registered at op.gg after a namechange)

So I think you fixed it, thanks!

@tGecko
Copy link
Owner

tGecko commented Dec 6, 2022

Thank you very much for your feedback.

@tGecko tGecko closed this as completed Dec 6, 2022
@cubedsphered
Copy link
Author

cubedsphered commented Dec 7, 2022

I've tested it using multiple lobbies, it works 100% of the time now -- sorry for the wait, I wanted to make sure I used it in more than 1 lobby before I made a comment again

@tGecko
Copy link
Owner

tGecko commented Dec 7, 2022

Thanks a lot for reporting the issue and the feedback @cubedsphered !

@IthielMS
Copy link

I've getting a trouble with the app, never worked to me in too many lobbies, i dont have idea of what can be, but dont show up names and dont appear the Summoner and Gamestate, just dont work. Can u help me?

@cubedsphered
Copy link
Author

This is a separate issue; please file under new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants