Various improvements of the code #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exception does not exist in most JS environments.
- Make commenting and code collapsing/expanding more easily.
- Also optimize surrogate pair handling using native String.codePointAt(). - ref: https://www.w3.org/TR/css-syntax-3/#input-preprocessing
- Ensure equality after re-serialization and re-tokenization. e.g. '"\n' === (tokenize) BADSTRING WS EOF <===> (serialize) '"\n '
|
Comprehensive, thanks! Especially thanks with the use of the Node-related loader stuff, I was cargo-culting that because I don't actually do anything in Node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the commit messages.