Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation + One (optional) change in fullscreen behavior #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kekh
Copy link

@kekh kekh commented Sep 13, 2015

Hi,

Here is my first contribution to this awesome (and probably the most helpful) Firefox extension.
About the small change, I've just added a preference to collapse or not the tab bar when switch to fullscreen...
And I have few other ideas for later!

Cheers, and thank you so much for keeping TK alive and active!

@PikachuEXE
Copy link
Member

Thanks for contributing!
I think it's best to only have one kind of change in one Pull Request to make it easier to be reviewed.
Can you change this PR to only have the fullscreen behavior change first?
You can submit the French translation later :)

@kekh
Copy link
Author

kekh commented Sep 13, 2015

Well I don't how to do that from the Github GUI :-/
Anyway I made 2 distincts commits so is not that enough adequate for you review it? If not, please explain to me how to edit or delete this pull request, I begin with Git... Thanks!

@PikachuEXE
Copy link
Member

Open a new branch, then cherry pick the commit(s) you want.
When the branch is ready, push to GitHub, then go the your repo's page and start another Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants