Changing error code for AuthErrorStates.NotRequired to 406 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChairmanMa0
reviewed
Aug 11, 2021
ChairmanMa0
reviewed
Aug 11, 2021
Co-authored-by: ChairmanMa0 <jsliu78@gmail.com>
Co-authored-by: ChairmanMa0 <jsliu78@gmail.com>
cgore1
approved these changes
Aug 11, 2021
rxing-tableau
approved these changes
Aug 11, 2021
|
@jakeichikawasalesforce Pls tag the release (2.4.0) after it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the error code distinct for AuthErrorStates.NotRequired, rather than simply a 400 error. This will allow the client (e.g. Tableau) to differentiate between errors more reliably. Adjusted tests accordingly (test_endpoint_handler.py, test_endpoints_handler.py, and test_service_info_handler.py).
This change also bumps the version to 2.4.0, and makes note of the new toggle to turn off evaluate API.