Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

grbritz
Copy link
Contributor

@grbritz grbritz commented May 6, 2020

No description provided.

@grbritz grbritz requested a review from t8y8 May 6, 2020 00:21
Copy link
Contributor

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a half done review.

I realized that you don't have much (any) error checking for calls out to the metadata API and results, my pager will handle some of that for you, so I'm going to finish that before I hit the second half.


query = """
{
customSQLTablesConnection(first: 20, after: AFTER_TOKEN_SIGNAL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about me merging my graphql pager so you can use it -- Don't have to block on that for this review but reminder to both us us that I said I'd do that :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants