Skip to content

fix: handle parameters for view filters #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: handle parameters for view filters #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tableauserverclient/server/request_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,14 @@ def parameter(self, name: str, value: str) -> Self:
Self
The current object
"""
self.view_parameters.append((name, value))
prefix = "vf_Parameters."
if name.startswith(prefix):
proper_name = name
elif name.startswith("Parameters."):
proper_name = f"vf_{name}"
else:
proper_name = f"{prefix}{name}"
self.view_parameters.append((proper_name, value))
return self

def _append_view_filters(self, params) -> None:
Expand Down
14 changes: 10 additions & 4 deletions test/test_request_option.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,14 +321,20 @@ def test_filtering_parameters(self) -> None:
opts = TSC.PDFRequestOptions()
opts.parameter("name1@", "value1")
opts.parameter("name2$", "value2")
opts.parameter("Parameters.name3", "value3")
opts.parameter("vf_Parameters.name4", "value4")
opts.page_type = TSC.PDFRequestOptions.PageType.Tabloid

resp = self.server.workbooks.get_request(url, request_object=opts)
query_params = parse_qs(resp.request.query)
self.assertIn("name1@", query_params)
self.assertIn("value1", query_params["name1@"])
self.assertIn("name2$", query_params)
self.assertIn("value2", query_params["name2$"])
self.assertIn("vf_parameters.name1@", query_params)
self.assertIn("value1", query_params["vf_parameters.name1@"])
self.assertIn("vf_parameters.name2$", query_params)
self.assertIn("value2", query_params["vf_parameters.name2$"])
self.assertIn("vf_parameters.name3", query_params)
self.assertIn("value3", query_params["vf_parameters.name3"])
self.assertIn("vf_parameters.name4", query_params)
self.assertIn("value4", query_params["vf_parameters.name4"])
self.assertIn("type", query_params)
self.assertIn("tabloid", query_params["type"])

Expand Down
Loading