Skip to content

@W-19831625: Add UAT support to TSC JWT Login #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2025
Merged

@W-19831625: Add UAT support to TSC JWT Login #1671

merged 3 commits into from
Oct 22, 2025

Conversation

@BereketBirbo
Copy link
Contributor

added UAT (unified access token/ tableau cloud unified jwt) support for TSC JWT login

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @BereketBirbo is an internal user so signing the CLA is not required. However, we need to confirm this.

@bcantoni bcantoni closed this Oct 20, 2025
@bcantoni
Copy link
Contributor

Close and reopen to see if it clears the CLA issue.

@bcantoni bcantoni reopened this Oct 20, 2025
@bcantoni
Copy link
Contributor

bcantoni commented Oct 20, 2025 •
edited
Loading

@BereketBirbo please update your PR to fix the Black formatting issues (docs here: https://tableau.github.io/server-client-python/docs/dev-guide#code-and-commit)

@BereketBirbo
Copy link
Contributor Author

@bcantoni I have fixed the black formatting issues. Thank you

jorwoods
jorwoods reviewed Oct 20, 2025
View reviewed changes
tableauserverclient/models/tableau_auth.py Outdated
def __init__(
self,
jwt: str,
isUat: Optional[bool] = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is None a valid value for isUat? Optional indicates that it is.

Copy link
Contributor Author

@BereketBirbo BereketBirbo Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, but I just pushed another version making isUat just True or False as that is more clear

@BereketBirbo
Copy link
Contributor Author

@bcantoni @jorwoods could you review my changes again? thank you

@BereketBirbo BereketBirbo requested a review from jorwoods October 21, 2025 22:43
bcantoni
bcantoni approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good - thanks @BereketBirbo for the changes

@bcantoni bcantoni merged commit cba111a into tableau:development Oct 22, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcantoni bcantoni bcantoni approved these changes

+1 more reviewer

@jorwoods jorwoods jorwoods approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BereketBirbo @bcantoni @jorwoods