Skip to content

D45 docs v06.1 (partial update) #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2018
Merged

D45 docs v06.1 (partial update) #290

merged 3 commits into from
Apr 26, 2018

Conversation

d45
Copy link
Contributor

@d45 d45 commented Apr 25, 2018

This PR points developers to the gh-pages branch for making doc updates.

@d45 d45 requested review from graysonarts and t8y8 April 25, 2018 22:12
Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 after a small change.

The . method will run over pytest code or other eggs installed as part of dev dependancies


- Only touch the minimal amount of files possible while still accomplishing the goal.
- Only touch the fewest number of files possible while still accomplishing the goal.
- Ensure all indentation is done as 4-spaces and your editor is set to unix line endings.
- The code matches PEP8 style guides. If you cloned the repo you can run `pycodestyle .`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycodestyle server-client-python test samples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I think you mean instead of "The code matches PEP8 style guides. If you cloned the repo you can run pycodestyle ."

We should change this to:

The code matches PEP8 style guides. If you cloned the repo you can run pycodestyle server-client-python test samples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t8y8 Is that correct?

Added Tyler's correction for pycodestyle.
@d45
Copy link
Contributor Author

d45 commented Apr 26, 2018

Made Tyler's change. Squashing and merging.

@d45 d45 merged commit c8e05d5 into tableau:gh-pages Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants