D45 docs v06.1 #300
Merged
D45 docs v06.1 #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Tyler's correction for pycodestyle.
…into d45_docs_v06.1
graysonarts
suggested changes
Jun 1, 2018
docs/dev-guide.md
Outdated
| - Only touch the fewest number of files possible while still accomplishing the goal. | ||
| - Ensure all indentation is done as 4-spaces and your editor is set to unix line endings. | ||
| - The code matches PEP8 style guides. If you cloned the repo you can run `pycodestyle .` | ||
| - The code matches PEP8 style guides. If you cloned the repo you can run `pycodestyle server-client-python test samples` |
There was a problem hiding this comment.
this should be pycodestyle tableauserverclient test samples
There was a problem hiding this comment.
Updated the pycodestyle command as suggested.
docs/versions.md
Outdated
| ```py | ||
| import tableauserverclient as TSC | ||
|
|
||
| server = TSC.Server('http://SERVER_URL') |
There was a problem hiding this comment.
probably have it be server = TSC.Server('http://SERVER_URL', use_server_version=True) since that's more compact
There was a problem hiding this comment.
Yes. That is pretty slick.
docs/versions.md
Outdated
| server.version = '2.6' | ||
|
|
||
|
|
||
| >>>>>>> 87acd20... Update versions.md (#195) |
There was a problem hiding this comment.
There is a conflict here. You need to resolve that before we push this.
t8y8
approved these changes
Jun 4, 2018
Updated command to: pycodestyle tableauserverclient test samples
updated example to use the more compact and elegant: `use_server_version=True`
|
I resolved the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The biggest part of this update is to api-ref.md. I did a diff between the v4.1 release and the v6.1 and then tried to add every significant change. I left out some things, for example, the
targetclass isn't listed separately. I just lumped it under subscriptions (as the target member).I'd like to get this PR merged to gh-pages, so that we can make smaller, faster, incremental updates. Once a year is not often enough!