Skip to content

View docs #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2019
Merged

View docs #390

merged 4 commits into from
Jan 29, 2019

Conversation

shinchris
Copy link
Contributor

Docs on views were a bit outdated. Updated fields and added more methods. Also added information about view filters for CSVRequestOptions, ImageRequestOptions, and PDFRequestOptions.

Found some issues with the code itself while updating docs:

Once the above issues are resolved, I will update the docs for them.

@shinchris shinchris requested review from mbren and d45 January 25, 2019 22:46
mbren
mbren approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@mbren mbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Chris!

@mbren mbren merged commit c48f3ef into gh-pages Jan 29, 2019
@d45
Copy link
Contributor

d45 commented Jan 29, 2019 •
edited
Loading

Yes! Thanks, @shinchris ! Looks good.

@shinchris shinchris deleted the view_docs branch February 20, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbren mbren mbren approved these changes

@d45 d45 Awaiting requested review from d45

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shinchris @d45 @mbren