Skip to content

Https link #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

Https link #435

merged 1 commit into from
Jul 25, 2019

Conversation

coliff
Copy link
Contributor

@coliff coliff commented May 11, 2019

No description provided.

jacalata
jacalata approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me - is there any potential downside?

@coliff
Copy link
Contributor Author

coliff commented Jul 25, 2019

No downside. Http redirects to https anyway - so this saves a redirect and is slightly faster.

@jacalata jacalata merged commit 8ab1345 into tableau:gh-pages Jul 25, 2019
@coliff coliff deleted the patch-2 branch January 23, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacalata jacalata jacalata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coliff @jacalata