Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load(patch): patch sheet with different patch types #123

Merged
merged 25 commits into from
Aug 20, 2024
Merged

Conversation

wenchy
Copy link
Member

@wenchy wenchy commented Aug 12, 2024

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 65.31792% with 120 lines in your changes missing coverage. Please review.

Project coverage is 55.11%. Comparing base (f72bc7f) to head (3f7794c).
Report is 1 commits behind head on master.

Files Patch % Lines
proto/tableaupb/unittestpb/unittest.pb.go 35.64% 65 Missing ⚠️
internal/xproto/merge.go 0.00% 15 Missing ⚠️
proto/tableaupb/tableau.pb.go 39.13% 14 Missing ⚠️
load/load.go 78.72% 6 Missing and 4 partials ⚠️
internal/confgen/parser.go 57.89% 5 Missing and 3 partials ⚠️
proto/tableaupb/metabook.pb.go 0.00% 4 Missing ⚠️
cmd/tableauc/main.go 0.00% 3 Missing ⚠️
internal/confgen/confgen.go 66.66% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (f72bc7f) and HEAD (3f7794c). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (f72bc7f) HEAD (3f7794c)
24 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #123       +/-   ##
===========================================
- Coverage   67.56%   55.11%   -12.46%     
===========================================
  Files          44       74       +30     
  Lines        5368     9158     +3790     
===========================================
+ Hits         3627     5047     +1420     
- Misses       1275     3561     +2286     
- Partials      466      550       +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenchy wenchy marked this pull request as ready for review August 17, 2024 09:20
@wenchy wenchy requested a review from Kybxd August 17, 2024 09:20
@Kybxd Kybxd merged commit 461824e into master Aug 20, 2024
7 of 8 checks passed
@Kybxd Kybxd deleted the patch-sheet branch August 20, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants