Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom importer and avoid mutex lock for custom functions #22

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix custom importer and avoid mutex lock for custom functions #22

merged 1 commit into from
Jan 30, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jan 18, 2024

Two changes in this PR:

  1. Restore support of options[:importer] so that user can override importer.
  2. Port Avoid using Sprockets::Utils.module_include in SasscProcessor rails/sprockets#798 to here so that we can avoid a mutex lock, improving dev server's performance.

@ntkme
Copy link
Contributor Author

ntkme commented Jan 18, 2024

@johnnyshields Please take a look when you get a chance.

@ntkme
Copy link
Contributor Author

ntkme commented Jan 29, 2024

@johnnyshields Pinging again.

@johnnyshields johnnyshields merged commit 8be9431 into tablecheck:master Jan 30, 2024
@ntkme ntkme deleted the fix-importer-functions branch January 30, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntkme @johnnyshields