Restore import tracking from Sprockets::SassProcessor so that edits to secondary imports are tracked #29
Conversation
|
@botandrose can you please add some tests for this? |
|
@johnnyshields Sure, I'll see what I can do. It'll be a bit tricky, because I think I'm going to have to mutate files on the filesystem to verify the behavior from the outside, like the existing tests are doing. But, I'm sure I can come up with something. |
|
@johnnyshields Taking a look at this now, but FYI master is red. |
botandrose
force-pushed
the
fix-secondary-import-tracking
branch
from
a7ec979 to
700c840
Compare
|
@botandrose THANK YOU!!! This restores import tracking for me. WOW. I totally forgot what live reloading with CSS changes was like! |
…o secondary imports are tracked.
|
@nimmolo That's great to hear! @johnnyshields Okay, I force pushed so that the first commit is a failing test, and the second commit makes it green. At least on my machine. CI isn't running on the PR anymore for some reason, and master is red anyways, but hopefully this is enough for you to merge. |
|
Awesome, thanks! |
Hi folks! Thanks for dartsass-sprockets!
We ran into the issue of secondary imports not being tracked after converting our stylesheets to
@use. Restoring the import tracking from the SassProcessor superclass resolved the issue, and perhaps closes #26 too. @nimmolo can you try this branch and verify?