Use redirect to default env #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
asutula
commented
May 29, 2024
| @@ -20,8 +20,7 @@ export default function NewProjectButton({ team }: { team: schema.Team }) { | |||
| } | |||
| onSuccess={(project) => { | |||
| router.refresh(); | |||
| // TODO: Deal with multiple envs | |||
| router.push(`/${team.slug}/${project.slug}/default`); | |||
| router.push(`/${team.slug}/${project.slug}`); | |||
There was a problem hiding this comment.
We can now simply link to or push to the team/project path and the environment resolution gets handled in a server side redirect.
There was a problem hiding this comment.
Here's the server side redirect logic.
Comment on lines
10
to
13
| let table = ""; | ||
| if (typeof searchParams.table === "string") { | ||
| table = `/${searchParams.table}`; | ||
| } |
There was a problem hiding this comment.
It optionally accepts a search param table that will result in redirecting to a table page inside an environment.
Comment on lines
+163
to
+168
| router.push( | ||
| `/${selectedTeam.slug}/${selectedProject.slug}${env ? `/${env.slug}/${def.slug}` : `?table=${def.slug}`}`, | ||
| ); | ||
| if (selectedProject.id === project?.id) { | ||
| void defsQuery.refetch(); | ||
| } |
There was a problem hiding this comment.
There is some special logic in the case of this table menu because it is used in two contexts:
- While viewing a table in the context of a project/environment
- While viewing any tableland table page where there is no project/environment
The logic is to use the env in our context if we have it (1. above), or default to the server side redirect if we don't (2. above).
Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
dtbuchholz
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that old URLs from before env was part of the url will keep working. It's also a more general way of handing navigation to an environment which will allow us to do something more sophisticated in the near future like read the correct env from the user session.