fix studio cli fails when rc file comes from general cli #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
asutula
previously approved these changes
Jun 7, 2024
joewagner
dismissed stale reviews from asutula and dtbuchholz
The base branch was changed.
joewagner
force-pushed
the
joe/cli-rcfile
branch
from
3395d4a
to
970b3e6
Compare
joewagner
force-pushed
the
joe/cli-rcfile
branch
from
970b3e6
to
6e5e4b0
Compare
joewagner
commented
Jun 13, 2024
| // The aliases config is used by @tableland/cli but not here. We want to allow | ||
| // people to use the same rc config for both, so we have to remove it here. | ||
| // @ts-expect-error the config type doesn't expect aliases | ||
| const { aliases: _, ...config } = conf.config; |
There was a problem hiding this comment.
This is the functional change.
We remove the aliases field from the config since it can't be used, and yargs crashes if it is present in the config Object.
| @@ -1,6 +1,6 @@ | |||
| import { type Schema as SDKSchema } from "@tableland/sdk"; | |||
| import { customType } from "drizzle-orm/sqlite-core"; | |||
| import { unescapeSchema } from "../helpers"; | |||
| import { unescapeSchema } from "../helpers.js"; | |||
There was a problem hiding this comment.
Testing this feature requires the use of npm link. When linking local builds you must include the file types, so I added them where needed.
|
I had to rebase and do a little bit of refactoring. This needs another review. |
asutula
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/tableland/issue/ENG-854/handle-aliases-field-in-rc-file