Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nonce) ensure incrby does not remove ttl #303

Merged
merged 1 commit into from
Jul 25, 2024
Merged

(nonce) ensure incrby does not remove ttl #303

merged 1 commit into from
Jul 25, 2024

Conversation

joewagner
Copy link
Contributor

@joewagner joewagner commented Jul 24, 2024

Overview

A user reported an issue creating an account this week. This resulted from the nonce delta key not having an expire.

Details

After some debugging and reading, I believe that the redis incrby command is clearing the expire value and the key is never being removed if the chain provider requests timeout or are throttled.

Here is the relevant error log when the provider request fails:

Error resetting delta: Error: could not coalesce error (error={ "code": -32007, "message": "15/second request limit reached - reduce calls per second or upgrade your account at quicknode.com" }, payload={ "id": 79, "jsonrpc": "2.0", "method": "eth_getTransactionReceipt", "params": [ "0x133cd82245df7ea68820efff1e0c34e3d5d8a1165f2cf927c51ae96736de571e" ] }, code=UNKNOWN_ERROR, version=6.12.1)
    at a (/var/task/packages/web/.next/server/chunks/947.js:319:281264)
    at D.getRpcError (/var/task/packages/web/.next/server/chunks/947.js:319:246129)
    at /var/task/packages/web/.next/server/chunks/947.js:319:239056
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'UNKNOWN_ERROR',
  error: {
    code: -32007,
    message: '15/second request limit reached - reduce calls per second or upgrade your account at quicknode.com'
  },
  payload: {
    method: 'eth_getTransactionReceipt',
    params: [
      '0x133cd82245df7ea68820efff1e0c34e3d5d8a1165f2cf927c51ae96736de571e'
    ],
    id: 79,
    jsonrpc: '2.0'
  },
  shortMessage: 'could not coalesce error'
}

Fix

This fix simply re-adds the expire value to the key when increment is called

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 3:59pm

@joewagner joewagner marked this pull request as ready for review July 24, 2024 17:19
@joewagner joewagner merged commit 7732132 into main Jul 25, 2024
4 checks passed
@joewagner joewagner deleted the joe/nonce branch July 25, 2024 04:53
asutula added a commit that referenced this pull request Aug 10, 2024
* (nonce) ensure incrby does not remove ttl (#303)

* Console refresh (#301)

* wip on new console

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* better layout for console and data table

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* more query validation, multiple statement support

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* remove old files

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* remove old code editor and deps

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* layout fix

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* working tabs

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* support esc key to cancel edit tab name

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* persisted tab data

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* shared wallet status component and supporting changes

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* little css cleanup

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* store tab data per project

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* combining conditional logic

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>

* native mode as project setting, scope tab results to env

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* support native mode in studio aliases

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* cli fix

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* add native_mode columns to cli tests

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Joe Wagner <joewagner@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>
asutula added a commit that referenced this pull request Aug 12, 2024
* (nonce) ensure incrby does not remove ttl (#303)

* Console refresh (#301)

* wip on new console

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* better layout for console and data table

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* more query validation, multiple statement support

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* remove old files

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* remove old code editor and deps

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* layout fix

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* working tabs

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* support esc key to cancel edit tab name

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* persisted tab data

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* shared wallet status component and supporting changes

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* little css cleanup

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* store tab data per project

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* combining conditional logic

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>

* native mode as project setting, scope tab results to env

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* support native mode in studio aliases

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* cli fix

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* add native_mode columns to cli tests

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Joe Wagner <joewagner@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>
asutula added a commit that referenced this pull request Aug 12, 2024
* Native mode (#308)

* (nonce) ensure incrby does not remove ttl (#303)

* Console refresh (#301)

* wip on new console

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* better layout for console and data table

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* more query validation, multiple statement support

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* remove old files

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* remove old code editor and deps

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* layout fix

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* working tabs

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* support esc key to cancel edit tab name

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* persisted tab data

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* shared wallet status component and supporting changes

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* little css cleanup

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* store tab data per project

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* combining conditional logic

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>

* native mode as project setting, scope tab results to env

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* support native mode in studio aliases

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* cli fix

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* add native_mode columns to cli tests

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Joe Wagner <joewagner@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>

* try out trpc utils invalidate

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

* fix missing nativeMode form value

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>

---------

Signed-off-by: Aaron Sutula <asutula@users.noreply.github.com>
Co-authored-by: Aaron Sutula <528969+asutula@users.noreply.github.com>
Co-authored-by: Aaron Sutula <asutula@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants