Skip to content

Commit

Permalink
EXADS Bid Adapter : update bidder code before adapter is published (#…
Browse files Browse the repository at this point in the history
…11464)

* First commit

* fix: readme.md

* fix: changed exads urls

* fix: Tools and suggestions related to the doc

* fix: from code review

* fix: from code review

* fix: from code review

* fix: error from code review - native example

* fox: from code review

* fix: from code review

* fix: from code review

* fix: native img set as mandatory

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: bidfloor and bidfloorcur set as optional

* fix: dsa

* fix: mananing multiple responses

* fix: unit test after code review

* fix: fixing native snippet code

* fix: from code review

* fix: video events after code review

* fix: video module into documentation

* fix: impression tracker for native

* fix: afeter code review

* fix: unit tests

* fix: added badv and bcat

* fix: video -> mimes and protocols

* fix

* fix: removed image_output and video_output params, forcing always html for rtb banner

* fix: gulp

* fix: added site.name

* fix: removed EXADS dir

* fix: after linting

* fix: unit tests

* fix: final dsa solution

* fix: dsa

* fix: fix instream example

* fix: doc media type context

* fix: documented the endpoint param into native section

* fix: related to markdown lint validation (#2)

* fix: from CR (#3)

* fix: changed bidder code to exads

* fix: userAgent

---------

Co-authored-by: tfoliveira <tfoliveira@users.noreply.github.com>
  • Loading branch information
giuseppe-exads and tfoliveira authored May 8, 2024
1 parent 5438945 commit 8c5c9d5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
9 changes: 4 additions & 5 deletions modules/exadsBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as utils from '../src/utils.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';

const BIDDER = 'exadsadserver';
const BIDDER = 'exads';

const PARTNERS = {
ORTB_2_4: 'ortb_2_4'
Expand Down Expand Up @@ -332,12 +332,11 @@ function getEnvParams() {
envParams.osName = 'MacOS';
} else if (envParams.userAgent.match(/Unix/i)) {
envParams.osName = 'Unix';
// TODO: what is userAgent.userAgent supposed to be?
} else if (envParams.userAgent.userAgent?.match(/Android/i)) {
} else if (envParams.userAgent.match(/Android/i)) {
envParams.osName = 'Android';
} else if (envParams.userAgent.userAgent?.match(/iPhone|iPad|iPod/i)) {
} else if (envParams.userAgent.match(/iPhone|iPad|iPod/i)) {
envParams.osName = 'iOS';
} else if (envParams.userAgent.userAgent?.match(/Linux/i)) {
} else if (envParams.userAgent.match(/Linux/i)) {
envParams.osName = 'Linux';
} else {
envParams.osName = 'Unknown';
Expand Down
8 changes: 4 additions & 4 deletions modules/exadsBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ adUnits =
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down Expand Up @@ -162,7 +162,7 @@ adUnits =
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down Expand Up @@ -237,7 +237,7 @@ adUnits = [{
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down Expand Up @@ -365,7 +365,7 @@ adUnits = [{
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/exadsBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { spec, imps } from 'modules/exadsBidAdapter.js';
import { BANNER, NATIVE, VIDEO } from '../../../src/mediaTypes.js';

describe('exadsBidAdapterTest', function () {
const bidder = 'exadsadserver';
const bidder = 'exads';

const partners = {
ORTB_2_4: 'ortb_2_4'
Expand Down

0 comments on commit 8c5c9d5

Please sign in to comment.