Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Get rid of Tabula::ZoneEntity #80

Open
jazzido opened this issue Apr 28, 2014 · 2 comments
Open

Get rid of Tabula::ZoneEntity #80

jazzido opened this issue Apr 28, 2014 · 2 comments

Comments

@jazzido
Copy link
Contributor

jazzido commented Apr 28, 2014

  • Move all of its methods to Rectangle2D
  • Make the "rectangular" entities (TextElement, Page, etc) inherit from Rectangle2D (we reopened it, anyway)
jazzido added a commit that referenced this issue Apr 28, 2014
@jazzido
starting with #80
926238d
jazzido added a commit that referenced this issue Apr 28, 2014
@jazzido
ready #80, test pass
4c882d8
@jazzido
Copy link
Contributor Author

jazzido commented Apr 28, 2014

@jeremybmerrill can you review this before I merge to master?

@jeremybmerrill
Copy link
Member

Looks good to me! I can't get the tests to run from current extractor-java, but it sounds like you could. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jazzido @jeremybmerrill