Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background job warnings & warn about auto-detect failures #433

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

mcharters
Copy link
Contributor

I noticed that when the table auto-detect job failed, it would stop users from trying to manually select tables from the document, even though having that job fail doesn't necessarily mean tables can't be extracted from the file.

I added warnings to background jobs, and changed the auto-detect job so that if an exception is thrown in tabula-java then the job completes with a warning instead of a general failure.

I also modified the web app to display warnings returned by the file upload process.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ct job failure from a fatal exception to a warning
@jazzido
Copy link
Contributor

jazzido commented Nov 26, 2015

OMG, @mcharters. You're one of the few —ouside the core team— that was brave enough to dive into the deep dark corners of Tabula's innards. Thanks a lot.

Please give me a couple days to review your PR.

Thanks again!

@mcharters
Copy link
Contributor Author

No problem! I've been using a modified version of Tabula for our team to do document processing, so I'm happy to try to contribute to the project where I can. The tool has been a big help for us!

jazzido added a commit that referenced this pull request Dec 10, 2015
Add background job warnings & warn about auto-detect failures
@jazzido jazzido merged commit 11f5a70 into tabulapdf:master Dec 10, 2015
jeremybmerrill pushed a commit that referenced this pull request Jun 26, 2018
Add background job warnings & warn about auto-detect failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants