Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

margin top and bottom in auto #489

Closed
proyb6 opened this issue Jan 26, 2018 · 2 comments
Closed

margin top and bottom in auto #489

proyb6 opened this issue Jan 26, 2018 · 2 comments

Comments

@proyb6
Copy link

proyb6 commented Jan 26, 2018

I tried to align vertical center an element within Flexbox and it works quite well, should be part of Tachyons?

.mt-auto { margin-top: auto; }
.mb-auto { margin-top: bottom; }

Tips:
https://hackernoon.com/flexbox-s-best-kept-secret-bd3d892826b6
@cristianofromagio
Copy link

Margin-auto left and right was released with v4 (see #390). In this same issue was mentioned vertical auto margins (some time later), I think they should be included too.

lowmess added a commit to lowmess/tachyons that referenced this issue May 5, 2018
@lowmess
Adds vertical margin auto classes
3e043ce 
Fixes tachyons-css#489
@lowmess lowmess mentioned this issue May 5, 2018
Merged
johno pushed a commit that referenced this issue Nov 10, 2018
@lowmess @johno
Adds vertical margin auto classes
cd64422 
Fixes #489
@mrmrs
Copy link
Member

mrmrs commented Nov 12, 2018

Believe you'd want align-items: center for vertically aligning flex children.

@mrmrs mrmrs closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrmrs @proyb6 @cristianofromagio